| --- Log opened Tue Mar 18 00:00:25 2014 | ||
| olofk_ | _franck__: I LOVE colors! Just bring it on | 07:05 |
|---|---|---|
| olofk_ | And I agree. The output is really messy | 07:05 |
| olofk_ | _franck__: I just saw your patch. I did some stuff locally yesterday and also decided to put a python implementation of which in utils.py :) | 07:06 |
| olofk_ | But I stole a 'which' implementation from the twisted framework after someone recommended it on stack overflow. Otherwise your patch is pretty much identical to what I had in mind :) | 07:07 |
| _franck_web_ | olofk_: I also stole my "which" :) | 07:55 |
| stekern | I've only stolen witches | 08:03 |
| stekern | and, can the text blink as well, to give that web 1.0 feel to it ;) | 08:03 |
| _franck_web_ | I could wrote something to have a scrolling as well :) | 08:04 |
| stekern | ;) | 08:08 |
| stekern | oh lord... I shouldn't have held off my changes to or1200-generic | 13:32 |
| _franck_web_ | First come, first served :) | 13:46 |
| stekern | _franck__: isn't parseArgs broken now? | 13:54 |
| stekern | https://github.com/openrisc/orpsoc-cores/commit/44ee3d8836b08918032b07963e14b6c94be6ceef#diff-930ca2e1debcb8d5569adaba507656f2R153 | 13:55 |
| stekern | is what I'm speaking about particularly | 13:55 |
| stekern | why is i increased twice there? | 13:56 |
| stekern | and here: https://github.com/openrisc/orpsoc-cores/commit/44ee3d8836b08918032b07963e14b6c94be6ceef#diff-930ca2e1debcb8d5569adaba507656f2R141 | 13:56 |
| stekern | why is i increased after the strtod(argv[i], NULL)? | 13:56 |
| stekern | ah, you changed the if-else, but it still looks broken... | 14:01 |
| _franck_web_ | men I can't tell. It was supposed to work | 14:02 |
| stekern | IMO, if-continue is harder to follow than if-else in that piece of code | 14:07 |
| stekern | is it even compiling? there's a missing } here, no? https://github.com/openrisc/orpsoc-cores/commit/44ee3d8836b08918032b07963e14b6c94be6ceef#diff-930ca2e1debcb8d5569adaba507656f2R166 | 14:09 |
| stekern | ah, no, sorry | 14:09 |
| stekern | it was just bad coding style ;) | 14:09 |
| stekern | I never omit the {} on the else if the if have them, so that threw me off | 14:10 |
| _franck_web_ | I'm sure if you insist like this you'll find something ;) | 14:12 |
| stekern | https://github.com/openrisc/orpsoc-cores/commit/44ee3d8836b08918032b07963e14b6c94be6ceef#diff-930ca2e1debcb8d5569adaba507656f2R139 | 14:12 |
| stekern | that is not right I think | 14:12 |
| stekern | argv will hold the string "--timeout" when the strtod is done on it | 14:13 |
| _franck_web_ | true | 14:13 |
| stekern | I'm changing other things in the parser, I'll fix it while I'm at it | 14:13 |
| _franck_web_ | thanks | 14:14 |
| stekern | first come, first served ;) | 14:14 |
| stekern | wasn't that what you said =) | 14:14 |
| _franck_web_ | you see you are serving me a code fix | 14:15 |
| _franck_web_ | :) | 14:15 |
| stekern | I more meant, I came first to see it, thus I was served with the task to fix it =) | 14:16 |
| _franck_web_ | anyway, my bad, should have been more careful | 14:18 |
| _franck_web_ | yeah we can also see it like this | 14:19 |
| stekern | _franck__: https://github.com/openrisc/orpsoc-cores/pull/42 | 14:58 |
| stekern | let's see how many bugs you can find back at me ;) | 14:58 |
| _franck_web_ | :) I'll try this tonight | 15:00 |
| olofk_ | Good to see that the cpp testbench gets some more love | 15:13 |
| olofk_ | That is a mess | 15:13 |
| _franck_web_ | olofk: could you try to add a dummy C src file in [verilator] section of or1200-generic and tell me if it works ? | 16:01 |
| stekern | olofk: yes, but as this first step I just wanted to push out what I had lying around, before it bitrots even further | 16:27 |
| stekern | as a follow-up, I want to do a mor1kx-generic system and move out the generic code | 16:28 |
| wkoszek | stekern: what's your e-mail? | 19:44 |
| wkoszek | juliusb_: Ping. | 19:44 |
| stekern | wkoszek: [email protected] | 20:04 |
| _franck__ | stekern: I found a bug in parseArgs :) see github | 20:52 |
| stekern | _franck__: tbh, do you ever care about setting the vcd filename? | 21:02 |
| _franck__ | no :) | 21:02 |
| stekern | me neither ;) | 21:02 |
| stekern | this is what I have in the eco32 tb https://github.com/skristiansson/orpsoc-cores/blob/eco32/systems/eco32f-verilator/bench/verilator/tb.cpp#L123 | 21:04 |
| _franck__ | much easier to read | 21:05 |
| stekern | but, otherwise, your incremental patch for the vcd file name is good | 21:09 |
| stekern | so... how does one get cpp files compiled with [verilator] src_files? | 21:18 |
| _franck__ | each core gets its src_files compiled and an archive is generated | 21:23 |
| stekern | but it tries to use gcc | 21:23 |
| _franck__ | then archives are exported in the build dir and linked together with the testbench | 21:24 |
| _franck__ | I didn't say it works :) | 21:24 |
| _franck__ | that's the theory | 21:24 |
| stekern | when I want it to use g++ | 21:24 |
| _franck__ | it is C (gcc) or systemC (g++) | 21:25 |
| _franck__ | we could add a third option to source_type 'CPP' | 21:27 |
| _franck__ | see section.py | 21:27 |
| stekern | mhmm | 21:30 |
| stekern | so this was probably the reason behind all the headscratching about detecting .c and .cpp files | 21:31 |
| stekern | would it be crazy to have c_source_files and cpp_source_files? | 21:32 |
| stekern | and source_files fall back to c_source_files | 21:32 |
| stekern | +have | 21:32 |
| _franck__ | why not, sounds good | 21:33 |
| stekern | _franck__: ok, here's my incremental patch with your suggestions incorporated: http://pastie.org/8948751 | 21:38 |
| stekern | + some more | 21:39 |
| _franck__ | great. You are right about moving common parts of tb.cpp to a core | 21:41 |
| _franck__ | we could implement a better (generic) parser :/ | 21:42 |
| stekern | yes, that's what I'm working on | 21:42 |
| stekern | and I figured it'd make more sense to do the utils package as a c++ class | 21:43 |
| stekern | can you somehow just "reopen" a pull-request | 21:46 |
| stekern | ? | 21:46 |
| _franck__ | I think if your commit has the same hash it knd of reopen it | 21:47 |
| olofk | Keep the pull requests coming. I have also thought about a generic parser. Is there a semi-standard way to do that in c++= | 21:50 |
| olofk | s/=/? | 21:50 |
| olofk | And c_source_files/cpp_source_files could work | 21:50 |
| olofk | But I'm also considering a mode where the core basically says, "Hey, it's so complex to compile my stuff, so I got my own Makefile that you can run to produce the .a" | 21:51 |
| _franck__ | olofk: can you tell me how to impoer Source in sections.py ? when I do "from fusesoc.simulator.verilator import Source" it mess things up | 21:56 |
| _franck__ | s/impoer/import | 22:00 |
| olofk | _franck__: I think I noticed something similar | 22:03 |
| olofk | And also, it looks like c files in top-level core doesn't work :( | 22:06 |
| _franck__ | olofk: I think this make it work: http://pastie.org/private/wyusj2dakhorjygzgntzq | 22:08 |
| olofk | Thanks. I'll try that | 22:08 |
| stekern | olofk: I think we should use getopt | 22:08 |
| olofk | I tried your import thing too. It's an extremely confusing error message | 22:08 |
| olofk | http://pastie.org/private/qtre0arabf1vujzvhwki6g | 22:09 |
| olofk | stekern: Sounds good. I want to let cores register arguments and let the top-level create a parser from all of them | 22:11 |
| olofk | Does that make sense? :) | 22:11 |
| _franck__ | olofk: (pastie) that's what I have | 22:11 |
| stekern | yes, that's kind of what I had in mind | 22:12 |
| olofk | stekern: Perfect | 22:15 |
| stekern | ooops, now I killed the "history" of the "old" pull-request | 22:15 |
| stekern | it's a bit silly this github pull-request workflow, me thinks | 22:16 |
| olofk | _franck__: Your pastie patch works for me | 22:17 |
| olofk | stekern: Got any better ideas? I like the visibility of the pull requests | 22:17 |
| stekern | it should somehow record the history, so you could say "okidoki, far points, I'll fix and repush to this branch" | 22:17 |
| stekern | s/far/fair | 22:17 |
| olofk | ah. yes. That would be nicer | 22:18 |
| _franck__ | stekern: yeah I noticed this too | 22:18 |
| stekern | ...like I just did, and then all _franck__s comments went away... | 22:18 |
| olofk | I never even got to see it :) | 22:18 |
| olofk | Damn, I'm slow | 22:18 |
| _franck__ | or we could use the old way and send email with patchs to the mailling list with git send-email | 22:19 |
| stekern | the pull-request is there, with the stuff _franck__ commented on fixed.. | 22:19 |
| olofk | _franck__: I'm pushing my version of your improve_verilator_root patch together with the pastie patch you sent me. | 22:32 |
| olofk | Is there a git way to set us both as authors? | 22:32 |
| _franck__ | just add my signedoff if you want | 22:33 |
| olofk | Cool. I'll do that | 22:33 |
| _franck__ | next thing I'll do is move verilog and vpi to section.py. Are you ok for that ? | 22:34 |
| _franck__ | then I'll add vhdl | 22:34 |
| olofk | _franck__: I'm a bit worried that section.py will become very large, but you can add that stuff, and we can do a refactoring later on if that is needed | 22:36 |
| _franck__ | ok great | 22:37 |
| olofk | Got to sleep now, but tomorrow night I'll be on a train for 14 hours, so I expect to be ultra-productive then :) | 22:44 |
| --- Log closed Wed Mar 19 00:00:27 2014 | ||
Generated by irclog2html.py 2.15.2 by Marius Gedminas - find it at mg.pov.lt!